Skip to content

DOCSP-57631: Fix js-express GitHub workflow#83

Merged
cbullinger merged 1 commit intodevelopmentfrom
bug/docsp-57631-js-express-workflow
Feb 9, 2026
Merged

DOCSP-57631: Fix js-express GitHub workflow#83
cbullinger merged 1 commit intodevelopmentfrom
bug/docsp-57631-js-express-workflow

Conversation

@cbullinger
Copy link
Copy Markdown
Collaborator

Update workflow so JS PR check fails if unit tests fail (integration tests are lenient)

Copy link
Copy Markdown
Collaborator

@dacharyc dacharyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof - thank you for fixing this up!


- name: Run unit tests
working-directory: mflix/server/js-express
run: npm run test:unit -- --json --outputFile=test-results-unit.json || true
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♀️

@cbullinger cbullinger merged commit 1cb591b into development Feb 9, 2026
1 check passed
@cbullinger cbullinger deleted the bug/docsp-57631-js-express-workflow branch February 9, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants